Skip to content

Added the missing conversation last reply action #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
raldred wants to merge 4 commits into from
Closed

Added the missing conversation last reply action #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f5a577
Added the missing conversation last reply action
raldred May 30, 2018
316fe8a
updated readme to include
raldred May 30, 2018
dbb0887
Cleanup stray comment
raldred May 30, 2018
34d1580
Merge branch 'master' into conversations-last-reply
theandrewykim Nov 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,12 @@ intercom.conversations.reply(id: conversation.id, type: 'admin', admin_id: '123'
# Reply and Close
intercom.conversations.reply(id: conversation.id, type: 'admin', admin_id: '123', message_type: 'close', body: 'bar')

# Admin reply to last conversation
intercom.conversations.reply_to_last(intercom_user_id: '5678', type: 'admin', admin_id: '123', message_type: 'comment', body: 'bar')

# User reply to last conversation
intercom.conversations.reply_to_last(intercom_user_id: '5678', type: 'user', message_type: 'comment', body: 'bar')

# ASSIGNING CONVERSATIONS TO ADMINS
intercom.conversations.reply(id: conversation.id, type: 'admin', assignee_id: assignee_admin.id, admin_id: admin.id, message_type: 'assignment')

Expand Down
6 changes: 6 additions & 0 deletions lib/intercom/service/conversation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ def reply(reply_data)
collection_class.new.from_response(response)
end

def reply_to_last(reply_data)
collection_name = Utils.resource_class_to_collection_name(collection_class)
response = @client.post("/#{collection_name}/last/reply", reply_data)
collection_class.new.from_response(response)
end

def open(reply_data)
reply reply_data.merge(message_type: 'open', type: 'admin')
end
Expand Down
10 changes: 10 additions & 0 deletions spec/unit/intercom/conversation_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@
client.conversations.reply(id: '147', type: 'user', body: 'Thanks again', message_type: 'comment', user_id: 'ac4', attachment_urls: ["http://www.example.com/attachment.jpg"])
end

it 'user replies to last conversation' do
client.expects(:post).with('/conversations/last/reply', { type: 'user', body: 'Thanks again', message_type: 'comment', user_id: 'ac4' }).returns(test_conversation)
client.conversations.reply_to_last(type: 'user', body: 'Thanks again', message_type: 'comment', user_id: 'ac4')
end

it 'admin replies to last conversation' do
client.expects(:post).with('/conversations/last/reply', { type: 'admin', body: 'Thanks again', message_type: 'comment', user_id: 'ac4', admin_id: '123' }).returns(test_conversation)
client.conversations.reply_to_last(type: 'admin', body: 'Thanks again', message_type: 'comment', user_id: 'ac4', admin_id: '123')
end

it 'opens a conversation' do
client.expects(:post).with('/conversations/147/reply', { type: 'admin', message_type: 'open', conversation_id: '147', admin_id: '123'}).returns(test_conversation)
client.conversations.open(id: '147', admin_id: '123')
Expand Down