Skip to content

Conversation

@theandrewykim
Copy link
Contributor

For #396

Copy link
Contributor

@jonnyom jonnyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

@choran choran added the ruby label Sep 12, 2018
@choran
Copy link
Member

choran commented Sep 21, 2018

looks good @theandrewykim nice work.
It might be a little confusing to have a delete and a hard delete now that the terms are archive and permanently delete on the API. If you have time would it be possible to add a wrapper to alias the current delete so that we can use archive instead of delete?
Also, if you have the code you used here could you add an example for the readme?
If you dont have the time we can merge this and I can open a backlog item to alias it and update the readme

@theandrewykim theandrewykim merged commit 55ef6c8 into master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants