feat(Staking): refactor

[danielsimao]

Interbtc UI Pull Request Template

Description

Missing freeStakable

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
interbtc-ui-interlay	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2023 11:58am
interbtc-ui-interlay-testnet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2023 11:58am
interbtc-ui-kintsugi	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2023 11:58am
interbtc-ui-kintsugi-testnet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2023 11:58am

[github-actions]

Running Lighthouse audit...

[tomjeatt]

Looks good—couple of very minor comments, not blockers. I would hold off on merging until Interlay testnet is upgraded though, so that we can test on both testnets.

[tomjeatt]

There's a bug with this release—if a user is connected with an account that has an staking balance, the application crashes:

TypeError: window.bridge.api.rpc.escrow.freeStakable is not a function
    at l (use-get-account-staking-data.tsx:52:53)

@peterslany could you have a look at this? I think it's related to the bug fix for reward estimation.

[peterslany]

There's a bug with this release—if a user is connected with an account that has an staking balance, the application crashes:

TypeError: window.bridge.api.rpc.escrow.freeStakable is not a function
    at l (use-get-account-staking-data.tsx:52:53)

@peterslany could you have a look at this? I think it's related to the bug fix for reward estimation.

@tomjeatt this issue is probably because the nodes UI uses are still runing old version where the freeStakable RPC call is not exposed

[tomjeatt]

@tomjeatt this issue is probably because the nodes UI uses are still runing old version where the freeStakable RPC call is not exposed

Thanks @peterslany—can you handle updating this? Would be great to get this wrapped up,

[peterslany]

@tomjeatt this issue is probably because the nodes UI uses are still runing old version where the freeStakable RPC call is not exposed

Thanks @peterslany—can you handle updating this? Would be great to get this wrapped up,

@tomjeatt yes, can you please share more details in which environment the mentioned bug occurs? So that I can ask Nikolai to check the version of RPC node.

[tomjeatt]

@tomjeatt yes, can you please share more details in which environment the mentioned bug occurs? So that I can ask Nikolai to check the version of RPC node.

I've seen it in all environments—very easy to replicate, you need to connect an account which has an existing stake and you'll see the staking page crash.

Edit:
Although the error on Kintsugi testnet is different—Error: Cannot read properties of undefined (reading 'name').Please refresh.