Repository navigation
Errors with Import when items are in the wrong path #291
Description
Consider the following situation: user commits an xml into class mapping directory and this xml contains classes and:
- EnsExportProduction
- Ens.Config.DefaultSettings.ESD
- EnsExportNotes
That causes these three items to be returned from ListItemsInFiles call in ImportRoutines (since ListItemsInFiles loads everything in the mapping directory without compiling and returns a full list of items, including these three items in our xml export).
But then in ImportRoutines we iterate this local of items and call ImportItem which tries to load the item from a correct place - which causes the error as the item does not exist in the right place.
Instead of an error, it should be reported as a warning.
Reacted by Tim Leavitt
Activity
cambot commentedon Apr 24, 2025
I think I just encountered this as well. I'm running v2.10.0
I had a lookup table that shifted spots in the repository. the internal reference pointed to a file that no longer exists. (I can't remember if I did this manually or the module ended up in this state, but I know I was modifying the export paths experimenting to find a folder structure I liked.)
Here is the exception I get:
SourceControl.Git.Utils.ImportItem()gets the date the file was modified. However, on my Windows system,##class(%File).GetFileDateModified(filename)returns-2when the file does not exist, which is what I see in the data global:GetTempFileAndRoutineTS()does not check the value before running$zdt(). I agree that the hooks should more gracefully catch/report this error instead of throwing an exception.