Repository navigation
Support explicit 'UnknownUser' unauthenticated access - #426
Conversation
|
The alternative sounds good to me. If John approves then let's go with that |
|
I will create a PR on the server manager repo so that I can include John as a reviewer. Given that we're updating the package, would it make sense to revisit the previously dropped PR? (Server Manager PR #367) We've agreed that |
|
Sure |
Upgrade @intersystems-community/intersystems-servermanager to 3.15.0-beta.3 and import its BasicAuthorization in place of the local copy. The password-prompt guard now uses auth.resolved(), which handles UnknownUser and empty passwords.
isc-bsaviano
left a comment
There was a problem hiding this comment.
We'll have to remember to update the server manager types version when server manager gets released.
|
How about we release the new types now? I don't see any risk but I could be wrong |
|
I think it's fine to wait. We'll just release the new server manager and types at the same time but before the other two extensions. |
|
Sounds good. I will leave this PR open then. |
|
You can merge it! We'll bump the server manager types version in the release preparation PR |
Companion to intersystems-community/intersystems-servermanager#366, which makes
"username": "UnknownUser"the explicit way to request unauthenticated access.Upgrades
@intersystems-community/intersystems-servermanagerand imports itsBasicAuthorizationin place of the local copy. The password-prompt guard now usesauth.resolved(), which handlesUnknownUserand empty passwords.