Skip to content

Support explicit 'UnknownUser' unauthenticated access - #426

Merged
isc-klu merged 1 commit into
intersystems:masterfrom
isc-klu:unknown-user
Oct 23, 2026
Merged

isc-klu merged 1 commit into
intersystems:masterfrom
isc-klu:unknown-user

Conversation

@isc-klu

@isc-klu isc-klu commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Companion to intersystems-community/intersystems-servermanager#366, which makes "username": "UnknownUser" the explicit way to request unauthenticated access.

Upgrades @intersystems-community/intersystems-servermanager and imports its BasicAuthorization in place of the local copy. The password-prompt guard now uses auth.resolved(), which handles UnknownUser and empty passwords.

@isc-klu
isc-klu requested a review from isc-bsaviano as a code owner October 19, 2026 18:13
@isc-klu
isc-klu marked this pull request as draft October 19, 2026 18:13
@isc-klu
isc-klu marked this pull request as ready for review October 19, 2026 18:53
@isc-bsaviano

Copy link
Copy Markdown
Collaborator

The alternative sounds good to me. If John approves then let's go with that

@isc-klu

isc-klu commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator Author

I will create a PR on the server manager repo so that I can include John as a reviewer.

Given that we're updating the package, would it make sense to revisit the previously dropped PR? (Server Manager PR #367)

We've agreed that httpAuthorizationHeader should always be a string (and "" when not applicable), so that portion wouldn't be included. That said, there may still be value in: Making IServerSpec the only type exchanged by Server Manager; and fully aligning IJSONServerSpec with the VS Code settings schema.

@isc-bsaviano

Copy link
Copy Markdown
Collaborator

Sure

@isc-klu isc-klu changed the title Support UnknownUser Support explicit 'UnknownUser' unauthenticated access Oct 23, 2026
Upgrade @intersystems-community/intersystems-servermanager to 3.15.0-beta.3
and import its BasicAuthorization in place of the local copy. The
password-prompt guard now uses auth.resolved(), which handles UnknownUser
and empty passwords.

@isc-bsaviano isc-bsaviano left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to remember to update the server manager types version when server manager gets released.

@isc-klu

isc-klu commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator Author

How about we release the new types now? I don't see any risk but I could be wrong

@isc-bsaviano

Copy link
Copy Markdown
Collaborator

I think it's fine to wait. We'll just release the new server manager and types at the same time but before the other two extensions.

@isc-klu

isc-klu commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator Author

Sounds good. I will leave this PR open then.

@isc-bsaviano

Copy link
Copy Markdown
Collaborator

You can merge it! We'll bump the server manager types version in the release preparation PR

@isc-klu
isc-klu merged commit f9bf967 into intersystems:master Oct 23, 2026
11 checks passed
@isc-klu
isc-klu deleted the unknown-user branch October 23, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants