-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(frontend): Add better frontend tracing #11244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (42.10%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #11244 +/- ##
==========================================
- Coverage 88.07% 87.88% -0.19%
==========================================
Files 1290 1290
Lines 58460 58972 +512
Branches 1965 1965
==========================================
+ Hits 51486 51827 +341
- Misses 6485 6656 +171
Partials 489 489
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Should we be concerned about the extra (albeit small) overhead associated with the extra API call to end the trace? Have you profiled this in action? |
|
I have profiled it on my test setup and the duration for the whole interaction is at about 50-65 ms as it does not really do much intensive action |
1 similar comment
|
I have profiled it on my test setup and the duration for the whole interaction is at about 50-65 ms as it does not really do much intensive action |

This PR gives us a generic way to associated API calls with a single event in the frontend. This is helpful to more easily find bottlenecks like serial API calls that do not depend on each other, API calls that are always grouped and access the same data and much more.
Changeset is kept minimal to get some practice with the process around the gathered analytics before we maybe extend OTEL to the frontend - which is much more involved data and security wise.