feat(android,ios): upgrade native SDK versions#3881
Conversation
mikehardy
left a comment
There was a problem hiding this comment.
That looks right to me so I approve though it be even more awesome if it included the similar android bump - here's the template to follow from the last one https://github.com/invertase/react-native-firebase/pull/3663/files - android is at 25.5.0 as of this typing
And as promised your 🎺 and 👼 singing 🎶 :-)
|
Doesn't look like there's been a new BoM for Android since 25.5.0 Ooops - Now i get what you mean 😅. On it |
|
Thanks for this, LGTM, though could you change https://github.com/invertase/react-native-firebase/blob/master/packages/app/package.json#L70 as well, thanks |
|
Added the Android upgrade. |
|
I think gradle is on v6 now, so that's okay, react-native hasn't been on v4 for a while? Should be fine? react-native 0.60 was the first to use it. So there are a few people using RNFBv6+ with RN59-, they need a warning that they will have to override things, so this is a major version bump for android :-) But version numbers are free! Just needs a changelog entry warning IMHO |
|
LGTM I wonder if we even need to major version this, I thought v6 was RN 60 min with 59 as "it works" - can't find the support table anywhere though 🙈 so can't confirm |
|
I think you are right, if RN59 is not officially supported, you could just put a very obvious change note for RN59 people. That seems friendly enough. It's a fail-fast as well they'll find out quite quickly, not like an obscure prod only runtime issue |
[publish] Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
[publish] Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
[publish] Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
[publish] Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
[publish] Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
I did this mostly to solve #3614 for everyone. Is this all that's required?
I think this should be fine, since the tests already override to SDK v6.27.0.
Looking at the changelog, I think the only changes that might change the dev experience are:
Installations change 3
Remote Config change 1
Storage change 2