fix(prompts): 🐛 prompt attention behaviors, add tests#8683
fix(prompts): 🐛 prompt attention behaviors, add tests#8683lstein merged 12 commits intoinvoke-ai:mainfrom
Conversation
|
The PR is still marked draft. Is it ready for review? |
|
The use case described in the description is working properly. However, I found a case that does not do what I'd expect:
Maybe the desired behavior is that any up/down-weighting action within a parentheses expands to the entire contents of the parentheses, but then there is a UI inconsistency, because if I select a single word within the parentheses, or even just have the insertion point adjacent to a word, then that single word is weighted:
|
lstein
left a comment
There was a problem hiding this comment.
I suggest making the weighting behavior when a phrase is selected consistent with the behavior when a single word is selected.
lstein
left a comment
There was a problem hiding this comment.
I've tried multiple scenarios, including changing weighting after selecting across heavily nested parentheses, and could not break it. Nice work!
Summary
Fixed a case where selecting and adjusting
bandcin the prompt(a b)+ cwould result in a mangled output, it now correctly adjusts to((a b)+ c)[attention]instead of(a (b)[attention].Added tests to ensure any changes follow desired behavior.
Related Issues / Discussions
Automatic Prompt Weighting Behavior Discussion
QA Instructions
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)