Skip to content

Fix: Improve non square bbox coverage for linear gradient tool. #8889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lstein merged 2 commits into from
Feb 21, 2026
Merged

Fix: Improve non square bbox coverage for linear gradient tool. #8889

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9977af0
Fix: Improve non square bbox coverage for linear gradient tool.
DustyShoe Feb 20, 2026
76c9256
Merge branch 'main' into Fix--linear-gradient-not-covering-nonsquare-…
lstein Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions ...keai/frontend/web/src/features/controlLayers/konva/CanvasTool/CanvasGradientToolModule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,19 +134,14 @@ export class CanvasGradientToolModule extends CanvasModuleBase {
};

if (settings.gradientType === 'linear') {
const bboxCenter = {
x: bboxInLayer.x + bboxInLayer.width / 2,
y: bboxInLayer.y + bboxInLayer.height / 2,
};
const cos = Math.cos(angle);
const sin = Math.sin(angle);
const halfWidth = (Math.abs(bboxInLayer.width * cos) + Math.abs(bboxInLayer.height * sin)) / 2;
const halfHeight = (Math.abs(bboxInLayer.width * sin) + Math.abs(bboxInLayer.height * cos)) / 2;
// Always render linear gradients on a rect that fully covers the bbox.
// Angle-dependent rect sizing can undershoot on non-square bboxes (e.g. 90deg on tall bboxes),
// leaving uncovered bands when the result is clipped back to bbox.
rect = {
x: bboxCenter.x - halfWidth,
y: bboxCenter.y - halfHeight,
width: Math.max(halfWidth * 2, 1),
height: Math.max(halfHeight * 2, 1),
x: bboxInLayer.x,
y: bboxInLayer.y,
width: Math.max(bboxInLayer.width, 1),
height: Math.max(bboxInLayer.height, 1),
};
}

Expand Down