Conversation
ghost
assigned
jacobheun
force-pushed
the
fix/node10
branch
2 times, most recently
from
7d9d586 to
ff02c08
Compare
|
Node 10.2 was released yesterday, it includes a fix for Experimental fs.promise Warnings when they're not actually used that resulted in js-ipfs cli errors. Once all dependency PRs are merged and released I will update the dependencies in this PR. We should be good for node 10 support. |
|
@jacobheun dignifiedquire/lock-me#3 seems to have been merged and released - can I review this and get this merged? |
src/core/boot.js
Outdated
| const waterfall = require('async/waterfall') | ||
| const series = require('async/series') | ||
| const extend = require('deep-extend') | ||
| const RepoErrors = require('ipfs-repo/src/errors') |
There was a problem hiding this comment.
This is an anti-pattern. Can we expose the repo errors through require('ipfs-repo').errors instead?
There was a problem hiding this comment.
Nice catch, and yes ipfs/js-ipfs-repo#171
package.json
Outdated
| "ipfs-block-service": "~0.14.0", | ||
| "ipfs-multipart": "~0.1.0", | ||
| "ipfs-repo": "~0.20.0", | ||
| "ipfs-repo": "^0.22.1", |
There was a problem hiding this comment.
We should keep the ~ for packages below 1.0.0, as stated in the js-ipfs guidelines.
There was a problem hiding this comment.
Yes, my mistake, ran the wrong install command. New ci build on the way!
|
👀 ing now |
alanshaw
left a comment
alanshaw
left a comment
There was a problem hiding this comment.
This LGTM. npm install works locally and all the tests pass. Just waiting on the result from CI.
|
@jacobheun could you setup commit signing for next time? https://help.github.com/articles/signing-commits-using-gpg/ |
4 participants
Opening this early to provide more visibility.
Update:
The jenkins builds are now running and working for node 10.0. There is an issue in node 10.1 with fs.promises warnings, mentioned below, but there is a fix already merged that should go out with the next release so I am going to leave that for now.
I will be working on getting all the dependency change PRs merged so I can get this PR finalized.
Things to fix:
Dependencies
The following PRs need to be completed prior to this release.