#639: Set the min-size of the input area and info area#646
Open
#639: Set the min-size of the input area and info area#646
Conversation
Reviewer's Guide by SourceryThis PR sets the minimum size of the input area and info area in the dialog to improve usability. It removes unnecessary includes and sets minimum sizes for these areas using Class diagram showing DialogPeer and DialogBase modificationsclassDiagram
class DialogBase {
+CreateInputArea(): GtkWidget*
-InputAreaMinHeight: int
}
class DialogPeer {
+CreateAllArea(): GtkWidget*
+CreateInfoArea(): GtkWidget*
-InfoAreaMinWidth: int
}
DialogBase <|-- DialogPeer
note for DialogBase "Added InputAreaMinHeight constant (50)"
note for DialogPeer "Added InfoAreaMinWidth constant (100)"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @lidaobing - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #646 +/- ##
=======================================
Coverage 52.47% 52.47%
=======================================
Files 64 64
Lines 8557 8557
=======================================
Hits 4490 4490
Misses 4067 4067 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Set the minimum size for the input and info areas in dialogs.
Enhancements: