Fix interrupt reply

[garlandz-db]

issue: #1100 (comment)

Changes in PR

• Added reply content properties for interrupt_request
• send_interupt_children => send_interrupt_children renaming
• Added test coverage to verify statuses are received

[garlandz-db]

@blink1073 how do i add the label? i dont see an option

[blink1073]

@ccordoba12 this fix breaks one of the spyder-kernels tests, but I believe it is the correct behavior.

[ccordoba12]

@impact27, could you take a look at this one, please?

[impact27]

In spyder kernel we want to be able to raise an interrupt from a thread on the main thread. This is done by
self.kernel._send_interupt_children()

I guess we just need to rename it self.kernel._send_interrupt_children() but that means we will have to change the minimum ipykernel version so this works

[blink1073]

We could make this backward compatible by having _send_interupt_children warn and call _send_interrupt_children.

[ccordoba12]

Well, the call to _send_interupt_children() is only present in our master branch, which hasn't been released yet. So, I think it's simpler if we skip the failing test so that this PR passes. Then we can switch to the new method name and increase our minimal IPykernel supported, as @impact27 suggested.

[ccordoba12]

@blink1073, our test suite should pass now thanks to PR spyder-ide/spyder-kernels#446. I went for a simpler solution: detect if the kernel has _send_interupt_children and if not use _send_interrupt_children.

[blink1073]

Confirmed, thanks all! I'll make a release early next week.