Allow setting cell name#652
Merged
Merged
Conversation
Member
|
cc @JohanMabille does this have an impact on debugger filenames. |
Contributor
|
Setting |
Collaborator
Author
|
Yes, it's a convenience for testing when the debugger is not involved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cell name is now of the form
/tmp/ipykernel_1789/2216019953.py, which makes it hard to compare error outputs with a traceback, because the cell name is embedded in it:For instance in nbclient, the new ipykernel will require rewriting our tests because we check strict output equality.
It would be nice to allow setting the cell name by passing it in an environment variable, e.g.:
This should be enough for tests not involving the debugger.