use message queue for abort_queues#853
Merged
blink1073 merged 1 commit intoipython:mainfrom Feb 4, 2022
Merged
Conversation
ensures queued messages are aborted, rather than racing with coroutine processing, which would complete too soon during asynchronous executions
Contributor
|
This test has failed twice in a row, seems relevant: |
Member
Author
|
Re-ran the tests and they passed. I don't really see how it could have affected that test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensures queued messages are aborted, rather than racing with coroutine processing which would complete too soon during asynchronous executions.
Discovered in ipython/ipyparallel#663 where making
do_executereturn a Future would cause abort tests to fail.