Don't error out when logging non-JSON serialisable values#516
Open
mathrick wants to merge 1 commit intoitamarst:masterfrom
Open
Don't error out when logging non-JSON serialisable values#516mathrick wants to merge 1 commit intoitamarst:masterfrom
mathrick wants to merge 1 commit intoitamarst:masterfrom
Conversation
Author
|
Is there anything else needed to move this forward? |
Author
|
@itamarst: ping? |
Owner
|
Sorry, must've missed this. And I guess I thought it was an OK idea back then. At minimum should use |
The serialiser now falls back on repr() to ensure some usable value can always be logged, even if no other serialiser exists for the value. Fixes itamarst#515
mathrick
force-pushed
the
fix-unserialisable-json
branch
from
ddc9c31 to
458bcf7
Compare
Author
|
Done, I've also adjusted the tests so they pass again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The serialiser now falls back on repr() to ensure some usable value can always be logged, even if no other serialiser exists for the value.
Fixes #515