Parsers: Fix parsing live_now and premiere_timestamp#4934
Merged
SamantazFox merged 1 commit intoNov 10, 2024
Conversation
9b3bf67 to
b2a8399
Compare
8 tasks
syeopite
approved these changes
Oct 4, 2024
SamantazFox
approved these changes
Nov 9, 2024
Member
|
Thanks again for contributing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4929
This pull request fixes the parsing for the
live_nowandpremiere_timestampvariables so that they work without the microformat data being present.Testing
live_now:/api/v1/videos/jfKfPfyJRdk->typeshould be"livestream"andliveNowshould betrueTesting
premiere_timestamp:Upcoming Live Streamssection/api/v1/videos/{videoID}=> should return a HTTP 500 status code and the following json{"error":"This live event will begin in 56 minutes."}