Error handling for diff() using Result#104
Open
qknight wants to merge 1 commit intoivanceras:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
motivation
this PR adds Result<...> to diff() and was added to give users some feedback what went wrong when trying to create a diff on a vdom with concepts which are not supported. i.e. "
" two roots as in this example.it works great if this two roots example is nested inside a div itself:
therefore the diff can now return InvalidRootNodeCount
details
Please have a look at:
motivation: a diff can't be computed for:
<div></div><div></div>I don't know why but I made sure that the user who tries this gets a error message: InvalidRootNodeCount until it is implemented.
tests status
just testruns all tests successfullyprototype code remark
i've been playing with websocket auto-reconnect and article updates based on html generated from pandoc. so it works great and it is fast! thanks for this wonderful tool!