Support Elixir 1.19 in CI and bump actions#88
Open
kianmeng wants to merge 1 commit intojaeyson:mainfrom
Open
Conversation
Reviewer's GuideUpdates all CI workflows for Typesense 26.0–28.0 to add an Elixir 1.19 / OTP 28 job variant and bump the GitHub checkout action from v4 to v6. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In
ci_v28.0.yml, the change so that the Elixir 1.18/OTP 27 combo now haslint: falsewhile the new 1.19/OTP 28 combo haslint: truelooks like a behavioral change to which configuration is linted; please confirm this is intentional to avoid silently reducing lint coverage on the older toolchain. - The new Elixir 1.19/OTP 28 matrix entries are added per workflow file with slightly different patterns (e.g., extra
lint: falseon 28.0 only); consider aligning the matrix definitions acrossci_v26.0.yml,ci_v27.0.yml,ci_v27.1.yml, andci_v28.0.ymlso that the behavior is consistent for each Typesense version.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `ci_v28.0.yml`, the change so that the Elixir 1.18/OTP 27 combo now has `lint: false` while the new 1.19/OTP 28 combo has `lint: true` looks like a behavioral change to which configuration is linted; please confirm this is intentional to avoid silently reducing lint coverage on the older toolchain.
- The new Elixir 1.19/OTP 28 matrix entries are added per workflow file with slightly different patterns (e.g., extra `lint: false` on 28.0 only); consider aligning the matrix definitions across `ci_v26.0.yml`, `ci_v27.0.yml`, `ci_v27.1.yml`, and `ci_v28.0.yml` so that the behavior is consistent for each Typesense version.
## Individual Comments
### Comment 1
<location path=".github/workflows/ci_v28.0.yml" line_range="51" />
<code_context>
steps:
- name: Checkout repo
- uses: actions/checkout@v4
+ uses: actions/checkout@v6
- name: Check for misspellings
</code_context>
<issue_to_address>
**issue (bug_risk):** Updating to `checkout@v6` here should be gated on that version actually existing.
To prevent CI failures, pin to the latest known-good major (or a specific commit) and only switch to v6 after it’s confirmed to exist and be stable.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| steps: | ||
| - name: Checkout repo | ||
| uses: actions/checkout@v4 | ||
| uses: actions/checkout@v6 |
There was a problem hiding this comment.
issue (bug_risk): Updating to checkout@v6 here should be gated on that version actually existing.
To prevent CI failures, pin to the latest known-good major (or a specific commit) and only switch to v6 after it’s confirmed to exist and be stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update CI workflows to test against newer Elixir/OTP combinations and bump the GitHub checkout action version.
CI: