Skip to content

Support Elixir 1.19 in CI and bump actions#88

Open
kianmeng wants to merge 1 commit intojaeyson:mainfrom
myfloss:support-elixir-119-in-ci
Open

Support Elixir 1.19 in CI and bump actions#88
kianmeng wants to merge 1 commit intojaeyson:mainfrom
myfloss:support-elixir-119-in-ci

Conversation

@kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Mar 4, 2026

Summary by Sourcery

Update CI workflows to test against newer Elixir/OTP combinations and bump the GitHub checkout action version.

CI:

  • Add Elixir 1.19 with OTP 28 test matrix entries across Typesense 26.0, 27.0, 27.1, and 28.0 CI workflows.
  • Upgrade GitHub Actions checkout step from v4 to v6 in all affected CI workflows.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 4, 2026

Reviewer's Guide

Updates all CI workflows for Typesense 26.0–28.0 to add an Elixir 1.19 / OTP 28 job variant and bump the GitHub checkout action from v4 to v6.

File-Level Changes

Change Details Files
Add Elixir 1.19 / OTP 28 CI matrix entries for Typesense 26.0–28.0 workflows.
  • Extend the job matrix in each versioned CI workflow to include a new combination using typesense version matching the workflow (26.0, 27.0, 27.1, 28.0) with OTP 28 and Elixir 1.19.
  • Ensure the new matrix entries in older workflows (26.0–27.1) keep lint disabled to match existing patterns.
  • Adjust the v28.0 workflow matrix so that the existing Elixir 1.18 / OTP 27 job is explicitly marked with lint: false and the new Elixir 1.19 / OTP 28 job runs with lint: true.
.github/workflows/ci_v26.0.yml
.github/workflows/ci_v27.0.yml
.github/workflows/ci_v27.1.yml
.github/workflows/ci_v28.0.yml
Update GitHub Actions checkout version used in CI workflows.
  • Bump actions/checkout from v4 to v6 in all modified CI workflow files to use the latest major version.
.github/workflows/ci_v26.0.yml
.github/workflows/ci_v27.0.yml
.github/workflows/ci_v27.1.yml
.github/workflows/ci_v28.0.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • In ci_v28.0.yml, the change so that the Elixir 1.18/OTP 27 combo now has lint: false while the new 1.19/OTP 28 combo has lint: true looks like a behavioral change to which configuration is linted; please confirm this is intentional to avoid silently reducing lint coverage on the older toolchain.
  • The new Elixir 1.19/OTP 28 matrix entries are added per workflow file with slightly different patterns (e.g., extra lint: false on 28.0 only); consider aligning the matrix definitions across ci_v26.0.yml, ci_v27.0.yml, ci_v27.1.yml, and ci_v28.0.yml so that the behavior is consistent for each Typesense version.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `ci_v28.0.yml`, the change so that the Elixir 1.18/OTP 27 combo now has `lint: false` while the new 1.19/OTP 28 combo has `lint: true` looks like a behavioral change to which configuration is linted; please confirm this is intentional to avoid silently reducing lint coverage on the older toolchain.
- The new Elixir 1.19/OTP 28 matrix entries are added per workflow file with slightly different patterns (e.g., extra `lint: false` on 28.0 only); consider aligning the matrix definitions across `ci_v26.0.yml`, `ci_v27.0.yml`, `ci_v27.1.yml`, and `ci_v28.0.yml` so that the behavior is consistent for each Typesense version.

## Individual Comments

### Comment 1
<location path=".github/workflows/ci_v28.0.yml" line_range="51" />
<code_context>
     steps:
       - name: Checkout repo
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6

       - name: Check for misspellings
</code_context>
<issue_to_address>
**issue (bug_risk):** Updating to `checkout@v6` here should be gated on that version actually existing.

To prevent CI failures, pin to the latest known-good major (or a specific commit) and only switch to v6 after it’s confirmed to exist and be stable.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

steps:
- name: Checkout repo
uses: actions/checkout@v4
uses: actions/checkout@v6
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Updating to checkout@v6 here should be gated on that version actually existing.

To prevent CI failures, pin to the latest known-good major (or a specific commit) and only switch to v6 after it’s confirmed to exist and be stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant