Skip to content

Conversation

@otaviojava
Copy link
Contributor

Fixes:

#403

Copy link
Member

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea to limit the possible numeric return types because float and double don't make sense, but we should still include long. I realize no one will supply that many entities to be updated/deleted at once and so int is more than enough to represent the value. However, long is very commonly used in applications so I think we should allow it as a return type as well.

Also, I made a couple of minor grammar corrections in the suggested changes.

@otaviojava
Copy link
Contributor Author

@njr-11 I am okay to keep long.

@otaviojava otaviojava merged commit e7dbeab into main Jan 4, 2024
@otaviojava otaviojava deleted the DATA-403 branch January 4, 2024 15:14
@KyleAure KyleAure mentioned this pull request Jan 8, 2024
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants