Add support for "Active VPC peering connections per VPC" quota.#576
Open
kevincox wants to merge 1 commit intojantman:developfrom
Open
Add support for "Active VPC peering connections per VPC" quota.#576kevincox wants to merge 1 commit intojantman:developfrom
kevincox wants to merge 1 commit intojantman:developfrom
Conversation
This is modelled after the "Subnets per VPC" quota which needs very similar logic however it is slightly more complicated since we need to consider peering connections where we the requester, accepter or both.
kevincox
commented
Sep 22, 2022
| if vpc['OwnerId'] != self.current_account_id: | ||
| continue | ||
|
|
||
| if vpc['Region'] != "us-west-2": # TODO: How to get current region? |
Author
There was a problem hiding this comment.
TODO: I'm not sure how to get the "active" region. Removing this check would result in VPCs being reported for multiple regions.
There was a problem hiding this comment.
I believe it should be self.conn._client_config.region_name ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for "Active VPC peering connections per VPC" quota.
This is modelled after the "Subnets per VPC" quota which needs very similar logic however it is slightly more complicated since we need to consider peering connections where we the requester, accepter or both.
Pull Request Checklist
writing tests for the code, that's fine, just mention that in the summary and either
ask for assistance, or clarify that you'd like someone else to handle the tests. PRs that
include complete test coverage will usually be merged faster.
tox -e docsconnect()andconnect_resource()methods, inherited fromawslimitchecker.connectable.Connectable
if you're working on a GitHub issue (i.e. "issue #x - "). Please
refrain from using the "fixes #x" notation unless you are sure that the
the issue is fixed in that commit.
Contributor License Agreement
This work is owned by my employer Yugabyte, however I have permission to release code under the AGPL v3 license as stated below.
By submitting this work for inclusion in awslimitchecker, I agree to the following terms:
is being made under the same license as the awslimitchecker project (the Affero GPL v3,
or any subsequent version of that license if adopted by awslimitchecker).
this pull request grants a perpetual, global, unlimited license for it to be used and distributed
under the terms of awslimitchecker's license.