Fix RDS storage quota "Units set to None" error#590
Open
bosmanx wants to merge 2 commits intojantman:developfrom
Open
Fix RDS storage quota "Units set to None" error#590bosmanx wants to merge 2 commits intojantman:developfrom
bosmanx wants to merge 2 commits intojantman:developfrom
Conversation
added 2 commits
November 5, 2025 10:53
Introduced a new function to handle the conversion of RDS storage limits from "Gigabytes" to "None" due to AWS's change in quota units. Updated the _RDSService class to utilize this converter and added corresponding unit tests to ensure functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix "Units set to "None"" error when retrieving RDS "Total storage for all DB instances" quota from Service Quotas. AWS changed the quota unit from "Gigabytes" to "None" without announcement, similar to the ELB issue fixed in #503. This PR adds a unit converter that accepts both "Gigabytes" and "None" units.
Pull Request Checklist
tox -e docs- unable to run locally due to Python 3.9 vs 3.11 version mismatch, but no documentation structure changes were madeContributor License Agreement
By submitting this work for inclusion in awslimitchecker, I agree to the following terms:
is being made under the same license as the awslimitchecker project (the Affero GPL v3,
or any subsequent version of that license if adopted by awslimitchecker).
this pull request grants a perpetual, global, unlimited license for it to be used and distributed
under the terms of awslimitchecker's license.