-
Notifications
You must be signed in to change notification settings - Fork 35
CMake improvements #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Waqar144
commented
Oct 9, 2025
- Allow disabling tests
- Use CMAKE_CURRENT_SOURCE_DIR when copy JSONTestSuite
|
Thank you for taking the time to send this. I'm reluctant to merge it since I'm not sure what the use case would be aside from development. I just run the makefile. I don't particularly like cmake so I'm only interested in maintaining it insofar as it helps people use the project. |
|
The use case is making it easy to embed this library in other projects. From the commit description:
By embedding a project I mean adding it as a git submodule or including it using something like CPM. https://github.com/cpm-cmake/CPM.cmake |
|
Having good VSCode integration is a good use case. I guess integration is too. However are you planning to do development work on json.cpp? Is this integration for a public project? Could you upstream your improvements? |
|
I don't have plans to do development work on this library atm. I am trying to get this library incorporated in a commercial closed sourced project. This patch is me trying to upstream Cmake changes that make integration via CPM simpler. On the c++ everything worked without issues so atm I don't have anything to upstream. |
|
You do have something to upstream, which is the work you did improving our CMake config. I need you to sync this PR to HEAD and secondly could you have it also delete these three lines (to fix an unrelated compiler crash flake): json.cpp/.github/workflows/ubuntu.yml Lines 30 to 32 in cb9d9a1
|
Otherwise if a project embeds this library, it tries to find JSONTestSuite in its top level CMakeLists.txt directory
g++ is crashing on aarch64
jart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM