Skip to content

Conversation

@Waqar144
Copy link
Contributor

@Waqar144 Waqar144 commented Oct 9, 2025

  • Allow disabling tests
  • Use CMAKE_CURRENT_SOURCE_DIR when copy JSONTestSuite

@jart jart self-requested a review October 22, 2025 18:36
@jart
Copy link
Owner

jart commented Oct 22, 2025

Thank you for taking the time to send this. I'm reluctant to merge it since I'm not sure what the use case would be aside from development. I just run the makefile. I don't particularly like cmake so I'm only interested in maintaining it insofar as it helps people use the project.

@jart jart closed this Oct 22, 2025
@Waqar144
Copy link
Contributor Author

The use case is making it easy to embed this library in other projects. From the commit description:

Otherwise if a project embeds this library, it tries to find JSONTestSuite
in its top level CMakeLists.txt directory

By embedding a project I mean adding it as a git submodule or including it using something like CPM. https://github.com/cpm-cmake/CPM.cmake

@jart
Copy link
Owner

jart commented Oct 22, 2025

Having good VSCode integration is a good use case. I guess integration is too. However are you planning to do development work on json.cpp? Is this integration for a public project? Could you upstream your improvements?

@Waqar144
Copy link
Contributor Author

I don't have plans to do development work on this library atm. I am trying to get this library incorporated in a commercial closed sourced project.

This patch is me trying to upstream Cmake changes that make integration via CPM simpler.

On the c++ everything worked without issues so atm I don't have anything to upstream.

@jart
Copy link
Owner

jart commented Oct 22, 2025

You do have something to upstream, which is the work you did improving our CMake config. I need you to sync this PR to HEAD and secondly could you have it also delete these three lines (to fix an unrelated compiler crash flake):

- arch: ppc64le
distro: ubuntu22.04
platform-name: linux/ppc64le
Then we should be good to go.

@jart jart reopened this Oct 22, 2025
Otherwise if a project embeds this library, it tries to find JSONTestSuite
in its top level CMakeLists.txt directory
g++ is crashing on aarch64
Copy link
Owner

@jart jart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jart jart merged commit 3a69398 into jart:main Oct 23, 2025
6 checks passed
cursor bot pushed a commit to Genuineh/json.cpp that referenced this pull request Nov 3, 2025
@Waqar144 Waqar144 mentioned this pull request Nov 11, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants