Improve CMake build for nixpkgs #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvements that make it easier to integrate with nixpkgs while still following CMake conventions. * Allow library to be either static or shared dependent on BUILD_SHARED_LIBS which is the default option * Added option to control whether to use vendored double-conversion * Used GNUInstallDirs for common variables for install
13 tasks
|
OK I hope we can do this! This very much makes it more "distro friendly", not just for Nixpkgs. |
|
Thanks so much! |
cursor bot
pushed a commit
to Genuineh/json.cpp
that referenced
this pull request
Nov 3, 2025
Improvements that make it easier to integrate with nixpkgs while still following CMake conventions. * Allow library to be either static or shared dependent on BUILD_SHARED_LIBS which is the default option * Added option to control whether to use vendored double-conversion * Used GNUInstallDirs for common variables for install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements that make it easier to integrate with nixpkgs while still following CMake conventions.