Add modalComponent prop#120
Merged
jasongaare merged 1 commit intojasongaare:masterfrom Sep 16, 2021
Merged
Conversation
Gabrielfcs
approved these changes
Aug 30, 2021
|
Excellent change, because in addition to allowing the use of other modal libs, it also allows the use of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, the default Modal component from react-native should be replaced by another one (typically, when using a library such as
react-native-web).The new prop
modalComponentwill allow you to achieve that, with minimal code changes.Feel free to ask if I need to edit something.