Skip to content

Add children to TooltipProps#154

Merged
jasongaare merged 2 commits intojasongaare:masterfrom
devon-whil:master
Jan 4, 2023
Merged

Add children to TooltipProps#154
jasongaare merged 2 commits intojasongaare:masterfrom
devon-whil:master

Conversation

@devon-whil
Copy link
Copy Markdown
Contributor

@devon-whil devon-whil commented May 11, 2022

Fixes the following error which occurs when trying to nest anything within the tooltip:

Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Tooltip> & Readonly<TooltipProps>'.

@devon-whil
Copy link
Copy Markdown
Contributor Author

@jasongaare What do you think about this?

@marcel925
Copy link
Copy Markdown

+1. Had the same error in TypeScript, and I was just going to make the same pull request 👍

@lornebb
Copy link
Copy Markdown

lornebb commented Sep 20, 2022

Currently have this exact fix on patch-package. Would love this merged. :)

@b-steel
Copy link
Copy Markdown

b-steel commented Oct 31, 2022

Same issue, would be nice to have implemented

@jlpopken
Copy link
Copy Markdown

jlpopken commented Dec 5, 2022

Also would love to see this merged into the project.

@jasongaare jasongaare merged commit 04bf6dd into jasongaare:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants