Fixes positioning issue #118 (add horizontalAdjustment prop)#162
Merged
jasongaare merged 2 commits intojasongaare:masterfrom Jan 4, 2023
Merged
Fixes positioning issue #118 (add horizontalAdjustment prop)#162jasongaare merged 2 commits intojasongaare:masterfrom
jasongaare merged 2 commits intojasongaare:masterfrom
Conversation
topherPedersen
changed the title
topherPedersen
changed the title
topherPedersen
changed the title
topherPedersen
changed the title
|
@jasongaare , I think this is a good solution to Issue #118 and should be accepted into this library 👍 |
|
when is it going to be merged, please so it as soon as possible. |
Owner
|
Seems reasonable! |
|
@jasongaare This still doesn't solve the problem. All I wanted was the tooltip to be position above the element it wraps but tooltip appears a bit towards the left instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adds a new prop, horizontalAdjustment, similar to the existing topAdjustment prop, which allows horizontal adjustment of the highlighted child view should the library get the alignment wrong. I ran into the same issue described in Issue #118 yesterday, a horizontal alignment problem, and created this new prop to solve this issue in my organization's app.