🐛 Fixed warning: 'View has a shadow set but cannot calculate shad…#86
Merged
jasongaare merged 2 commits intojasongaare:masterfrom Jul 24, 2020
1fabiopereira:master
Merged
🐛 Fixed warning: 'View has a shadow set but cannot calculate shad…#86jasongaare merged 2 commits intojasongaare:masterfrom 1fabiopereira:master
jasongaare merged 2 commits intojasongaare:masterfrom
1fabiopereira:master
Conversation
jasongaare
requested changes
Jun 15, 2020
Owner
jasongaare
left a comment
jasongaare
left a comment
There was a problem hiding this comment.
Hello! Thank you for this PR.
Could you please invert it though so that the shadows are enabled by default? i.e. could you:
- make the prop title
disableShadow(default false) - make the description something similar to: "When true, tooltips will not appear elevated. Disabling shadows will remove the warning: RCTView has a shadow set but cannot calculate shadow efficiently"
… change default behavior
Contributor
Author
|
Done! All changes that you proposed. |
Owner
|
wow I am terribly sorry I must have missed you made the changes! |
Owner
|
This is live in version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added option to enable or disable shadow, this avoid warnings on IOS devices.
fix: #81