Cancel interaction promise when component unmounts#91
Merged
jasongaare merged 3 commits intojasongaare:masterfrom Sep 14, 2020
Merged
Cancel interaction promise when component unmounts#91jasongaare merged 3 commits intojasongaare:masterfrom
jasongaare merged 3 commits intojasongaare:masterfrom
Conversation
Prevent dev warning: ``` Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in %s.%s, the componentWillUnmount method, ```
actually set value
jasongaare
requested changes
Aug 4, 2020
Owner
jasongaare
left a comment
jasongaare
left a comment
There was a problem hiding this comment.
Thanks for this simple, elegant solution! If you could just make one quick change I'll get this merged 💪🏻
|
|
||
| componentWillUnmount() { | ||
| Dimensions.removeEventListener('change', this.updateWindowDims); | ||
| this.interactionPromise && this.interactionPromise.cancel(); |
Owner
There was a problem hiding this comment.
small nit-pick, but for readability will you use this like you did below here, please?
if (this.interactionPromise) {
this.interactionPromise.cancel();
}
Contributor
Author
|
thanks @jasongaare, just updated 👍 |
Contributor
Author
|
@jasongaare okay to merge this? |
Owner
|
Released in version 1.1.11 sorry for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent dev warning: