forked from scream3r/java-simple-serial-connector
-
Notifications
You must be signed in to change notification settings - Fork 56
Issues/37 unittests #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4bdb6db
add basic unit test.
bmarwell 93b0582
Workaround for travis-ci-openjdk-bug
bmarwell 9972e7a
Remove hostname per comments
tresf 0190155
Enable test for unix too
tresf d13087b
Don't assume socat path
tresf de6676a
Show command *before* deadlock occurs :)
tresf e2c4457
Prevent deadlock when socat is missing
tresf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,3 +36,9 @@ target/ | |
|
|
||
| # IDE files: eclipse | ||
| .settings/ | ||
|
|
||
| # Java dumps | ||
| core.*.dmp | ||
| hs_err_pid*.log | ||
| javacore.*.txt | ||
| jitdump.*.dmp | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /* | ||
| * GNU Lesser General Public License v3.0 | ||
| * Copyright (C) 2019 | ||
| * | ||
| * This program is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU Lesser General Public | ||
| * License as published by the Free Software Foundation; either | ||
| * version 3 of the License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * Lesser General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Lesser General Public License | ||
| * along with this program; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
| */ | ||
|
|
||
| package jssc; | ||
|
|
||
| import static org.hamcrest.CoreMatchers.is; | ||
| import static org.junit.Assert.assertThat; | ||
|
|
||
| import java.io.IOException; | ||
| import java.io.UnsupportedEncodingException; | ||
| import jssc.junit.rules.VirtualPortRule; | ||
| import org.junit.Assume; | ||
| import org.junit.Rule; | ||
| import org.junit.Test; | ||
|
|
||
| public class VirtualPortTest { | ||
|
|
||
| private static final String HELLO_WORLD = "Hello, world!"; | ||
|
|
||
| private final byte[] bytes; | ||
|
|
||
| @Rule | ||
| public VirtualPortRule virtualPort = new VirtualPortRule(); | ||
|
|
||
| public VirtualPortTest() throws UnsupportedEncodingException { | ||
| this.bytes = HELLO_WORLD.getBytes("UTF-8"); | ||
| } | ||
|
|
||
| @Test | ||
| public void testOpenPort() throws IOException { | ||
| // given virtualcom port is available | ||
| Assume.assumeTrue(this.virtualPort.isAvailable()); | ||
|
|
||
| // given two virtual ports (null modem) | ||
| final SerialNativeInterface serial1 = new SerialNativeInterface(); | ||
| final long handle = serial1.openPort(this.virtualPort.getVirtualCom1().getAbsolutePath(), false); | ||
|
|
||
| final SerialNativeInterface serial2 = new SerialNativeInterface(); | ||
| final long handle2 = serial2.openPort(this.virtualPort.getVirtualCom2().getAbsolutePath(), false); | ||
|
|
||
| // when bytes are written to port 1 | ||
| serial1.writeBytes(handle, this.bytes); | ||
| serial1.closePort(handle); | ||
|
|
||
| // expect same output on port 2. | ||
| final byte[] readBytes = serial2.readBytes(handle2, this.bytes.length); | ||
| serial2.closePort(handle2); | ||
|
|
||
| final String readString = new String(readBytes, "UTF-8"); | ||
| assertThat(readString, is(HELLO_WORLD)); | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /* | ||
| * GNU Lesser General Public License v3.0 | ||
| * Copyright (C) 2019 | ||
| * | ||
| * This program is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU Lesser General Public | ||
| * License as published by the Free Software Foundation; either | ||
| * version 3 of the License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * Lesser General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Lesser General Public License | ||
| * along with this program; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
| */ | ||
|
|
||
| package jssc.junit.rules; | ||
|
|
||
| public interface BackgroundProcess extends Runnable { | ||
|
|
||
| Process getProcess(); | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,211 @@ | ||
| /* | ||
| * GNU Lesser General Public License v3.0 | ||
| * Copyright (C) 2019 | ||
| * | ||
| * This program is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU Lesser General Public | ||
| * License as published by the Free Software Foundation; either | ||
| * version 3 of the License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * Lesser General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Lesser General Public License | ||
| * along with this program; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
| */ | ||
|
|
||
| package jssc.junit.rules; | ||
|
|
||
| import static java.util.Arrays.asList; | ||
|
|
||
| import java.io.File; | ||
| import java.io.IOException; | ||
| import java.io.OutputStream; | ||
| import java.security.SecureRandom; | ||
| import java.util.ArrayList; | ||
| import java.util.Arrays; | ||
| import java.util.List; | ||
| import java.util.Random; | ||
| import java.util.concurrent.ExecutorService; | ||
| import java.util.concurrent.Executors; | ||
| import java.util.concurrent.Future; | ||
| import jssc.SerialNativeInterface; | ||
| import org.junit.rules.TestRule; | ||
| import org.junit.runner.Description; | ||
| import org.junit.runners.model.Statement; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class VirtualPortRule implements TestRule { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(VirtualPortRule.class); | ||
|
|
||
| private static final ExecutorService executor = Executors.newCachedThreadPool(); | ||
|
|
||
| private final List<Future<?>> processes = new ArrayList<Future<?>>(); | ||
|
|
||
| private OutputStream outputStream; | ||
|
|
||
| private boolean isAvailable; | ||
|
|
||
| private final Random random = new SecureRandom(); | ||
|
|
||
| private File virtualCom1; | ||
| private File virtualCom2; | ||
|
|
||
| public VirtualPortRule() { | ||
| } | ||
|
|
||
| @Override | ||
| public Statement apply(final Statement base, final Description description) { | ||
| // skip / prevent deadlock if socat isn't available | ||
| if (SerialNativeInterface.getOsType() == SerialNativeInterface.OS_WINDOWS || !execute("socat", "-V")) { | ||
| return new Statement() { | ||
| @Override | ||
| public void evaluate() throws Throwable { | ||
| base.evaluate(); | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| initUnix(description); | ||
|
|
||
| return new Statement() { | ||
|
|
||
| @Override | ||
| public void evaluate() throws Throwable { | ||
| try { | ||
| final BackgroundProcess socatProcess = openSocat(); | ||
| final Future<?> socatFuture = executor.submit(socatProcess); | ||
| VirtualPortRule.this.processes.add(socatFuture); | ||
|
|
||
| // Java 8: | ||
| // System.timemillis… | ||
| // while (!socatProcess.getProcess().isAlive()) { | ||
| // Thread.sleep(50); | ||
| // } | ||
|
|
||
| // java 6 way… pretend it is running. | ||
| Thread.sleep(500); | ||
|
|
||
| VirtualPortRule.this.isAvailable = true; | ||
|
|
||
| base.evaluate(); | ||
| } finally { | ||
| // stop socat | ||
| for (final Future<?> process : VirtualPortRule.this.processes) { | ||
| process.cancel(false); | ||
| } | ||
|
|
||
| executor.shutdown(); | ||
| } | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| private void initUnix(final Description description) { | ||
| final File testTargetDir = new File("./target").getAbsoluteFile(); | ||
| final File virtualPortsDir = new File(testTargetDir, "virtual-ports"); | ||
|
|
||
| virtualPortsDir.mkdirs(); | ||
|
|
||
| final String filename1 = String | ||
| .format("virtualcom-%s-%s-%d", description.getClassName(), description.getMethodName(), this.random.nextInt(10000)); | ||
| this.virtualCom1 = new File(virtualPortsDir, filename1); | ||
| final String fileName2 = String | ||
| .format("virtualcom-%s-%s-%d", description.getClassName(), description.getMethodName(), this.random.nextInt(10000)); | ||
| this.virtualCom2 = new File(virtualPortsDir, fileName2); | ||
| } | ||
|
|
||
| private BackgroundProcess openSocat() { | ||
| return new BackgroundProcess() { | ||
|
|
||
| private Process process; | ||
|
|
||
| @Override | ||
| public Process getProcess() { | ||
| return this.process; | ||
| } | ||
|
|
||
| @Override | ||
| public void run() { | ||
|
|
||
| try { | ||
| List<String> cmds = asList( | ||
| "socat", | ||
| "pty,link=" + VirtualPortRule.this.virtualCom1.getAbsolutePath() + ",rawer,echo=0", | ||
| "pty,link=" + VirtualPortRule.this.virtualCom2.getAbsolutePath() + ",rawer,echo=0" | ||
| ); | ||
| final ProcessBuilder processBuilder = new ProcessBuilder(cmds); | ||
| processBuilder.redirectErrorStream(true); | ||
|
|
||
| LOG.info("Process starting: {}", cmds); | ||
| this.process = processBuilder.start(); | ||
| LOG.info("Process started! [{}], ports: [{}] // [{}].", this.process, VirtualPortRule.this.virtualCom1.getName(), | ||
| VirtualPortRule.this.virtualCom2.getName()); | ||
| VirtualPortRule.this.outputStream = this.process.getOutputStream(); | ||
| this.process.waitFor(); | ||
| } catch (final IOException ioEx) { | ||
| throw new IllegalStateException("unable to start socat!", ioEx); | ||
| } catch (final InterruptedException interruptEx) { | ||
| Thread.currentThread().interrupt(); | ||
| LOG.debug("interrupted.", interruptEx); | ||
| this.process.destroy(); | ||
| } | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| public OutputStream getOutputStream() { | ||
| return this.outputStream; | ||
| } | ||
|
|
||
| public boolean isAvailable() { | ||
| return this.isAvailable; | ||
| } | ||
|
|
||
| public File getVirtualCom1() { | ||
| return this.virtualCom1; | ||
| } | ||
|
|
||
| public File getVirtualCom2() { | ||
| return this.virtualCom2; | ||
| } | ||
|
|
||
| /** | ||
| * Executes the provided command and waits for a zero (success) or non-zero (failure) return code | ||
| */ | ||
| private static boolean execute(String ... commands) { | ||
| LOG.debug("Executing: {}", Arrays.toString(commands)); | ||
| try { | ||
| // Create and execute our new process | ||
| Process p = Runtime.getRuntime().exec(commands); | ||
| // Consume output to prevent deadlock | ||
| while (p.getInputStream().read() != -1) {} | ||
| p.waitFor(); | ||
| return p.exitValue() == 0; | ||
| } | ||
| catch(InterruptedException ex) { | ||
| LOG.warn("InterruptedException waiting for a return value from {}", Arrays.toString(commands), ex); | ||
| } | ||
| catch(IOException ex) { | ||
| LOG.error("IOException executing: {}", Arrays.toString(commands), ex); | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "VirtualPortRule{" + "processes=" + this.processes | ||
| + ", outputStream=" + this.outputStream | ||
| + ", isAvailable=" + this.isAvailable | ||
| + ", random=" + this.random | ||
| + ", virtualCom1=" + this.virtualCom1 | ||
| + ", virtualCom2=" + this.virtualCom2 | ||
| + '}'; | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.