Open
Conversation
Author
|
@javan can you take a look when you have time? |
|
I think it would be better if whenever exposed a simple locking mechanism. # schedule.rb
acquire_lock do
# The user can decide what to do here, for example make an http request,
# inquiry with redis, check with consul, or use some other mechanism.
# If this method return true whenever will run the job/task/item.
# If defined, this block is invoked before every runner/task in the schedule.
true
end |
|
How are people handling this? I too have the exact same issue. |
|
@ausangshukla I would look at https://github.com/rails/solid_queue or https://github.com/bensheldon/good_job, both have support for scheduled jobs AFAIK. If you want to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have exported whenever tasks on multiple servers, but most of the crontab tasks have an implicit assumption that they should only be run once in their given time frame. Having multiple servers with the same crontab tasks obviously would break this assumption, leading to all kinds of weird bugs. Instead, what if we let the servers use a middleware (in this implementation, redis is used) to communicate and decide which server will run the task.
in
*.schedule.rbthe default value for
:redis_optionsisniland if it is set to something other than
nil, instead ofit would export
before executing the job, we would execute the
whenever_serverscript that would basically use atomic operations to decide if the job should run on this server on not (guaranteeing that the job is executed only once)