CRLF #2
Merged
CRLF #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks fine to me. I'm having a problem where the |
Contributor
|
(just verified that editor thing is 100% unrelated, totally a local config issue! 👍 ) |
Member
Author
|
I read about git log a bit more and it seems to always print out LF only, regardless of settings. |
Member
Author
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
CHANGES.mdfile is checked out on Windows with CRLF, the header detection and the check for an already existing version fail.With this fix, the checks are made with regular expressions to support CRLF and LF. The initial check for the header is also used to detect which newline style is used.
There are two open points:
git logprint out CRLFs on Windows?@tivac Can you check?
Fixes #1