-
-
Notifications
You must be signed in to change notification settings - Fork 113
Sets and ranges [...] #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nazarepiedady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peruibeloko, it is very good to me, and since you are also a maintainer, you could just approve and merge it if you agree with the updates that you made. 😉
|
@nazarepiedady Thanks for the review! I'd still like to wait for another review, as is the usual process :D Also, I still haven't been added as a maintainer just yet, so I still gotta wait a bit |
|
@peruibeloko, if you liked what you did, you can approve it to allow me to merge it as soon as possible. |
|
@jonnathan-ls, could you give your review or approval about this pull request? |
|
@gabifs, could you please finish the review of this pull request, and then merge it to the main branch? @gabifs, remember that from today and now, we shall use English to communicate, because this way the ultimate owner of the project can follow the progress and discussions of this branch of the project. Let's work. 💪 |
gabifs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.