Allow option to delete profiles#652
Merged
albertyw merged 6 commits intoDec 30, 2023
Merged
Conversation
Updated msg to be displayed with line breaks so new message can be shown in new line.
Added option to check for `SILKY_DELETE_PROFILES` set by user in settings file which if set true, all profiles will be deleted along with database clean function.
Added new configuration setting SILKY_DELETE_PROFILES.
for more information, see https://pre-commit.ci
viralj
commented
Apr 6, 2023
Contributor
Author
viralj
left a comment
viralj
left a comment
There was a problem hiding this comment.
Looks like correct update.
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
==========================================
+ Coverage 86.51% 86.59% +0.07%
==========================================
Files 52 52
Lines 2091 2103 +12
==========================================
+ Hits 1809 1821 +12
Misses 282 282
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Added new test that will test delete all profile functionality.
for more information, see https://pre-commit.ci
viralj
commented
Apr 6, 2023
Contributor
Author
viralj
left a comment
viralj
left a comment
There was a problem hiding this comment.
Added new test case
Contributor
Author
|
All checks have passed and the updated code implements helpful functionality. |
albertyw
approved these changes
Dec 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new config option that will allow user to clear profiler profiles from storage when Clear DB is called. This is helpful functionality especially in development environment where frequent DB cleaning is done.