Add feature to allow limiting of total notifications shown and queue the rest.#56
Open
jpuffer wants to merge 3 commits intojboesch:masterfrom
Open
Add feature to allow limiting of total notifications shown and queue the rest.#56jpuffer wants to merge 3 commits intojboesch:masterfrom
jpuffer wants to merge 3 commits intojboesch:masterfrom
Conversation
var in this case is hoisted to the top of the function and will blow out any passed value for ‘e’. In order to maintain code integrity, don’t re-var ‘e’ since it has already been declared. Now we could theoretically pass a value for ‘e’ and have it work correctly.
add feature to limit number of notifications that can be displayed concurrently, and queue up the rest to be displayed when there is room. Add example to set max notifications to 3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.