Focusable & Scrollable ‘LearnMoreModal‘

[JPKribs]

This feature request respects the following points:

• This feature has not already been requested on GitHub.
• I agree to follow Jellyfin's Code of Conduct.

Platform

tvOS

Describe the feature you'd like to see

Update the ‘LearnModeModal‘ overlay on tvOS to be focusable and scrollable when needed. Will likely want to use:

https://github.com/jellyfin/Swiftfin/blob/main/Shared/Extensions/ViewExtensions/Modifiers/ScrollIfLargerThanContainerModifier.swift

Or, update that modifier to be usages for our final result.

Original Reference: #1838 (review)

Example

[henryauryn]

Hey, I'd love to work on this as my first issue if it's still available.

[JPKribs]

Hey, I'd love to work on this as my first issue if it's still available.

It is available! As a note, there are still 2 modals for LearnMoreModal. We are in the process of unifying our settings so we have a single settings file that works for both tvOS and iOS. As a result, there LearnMoreModal stand along file is getting taken out as we finalize migrating over our last settings.

You will want to make your changes to to the LearnMoreModal found in the Form extension. Should be func learnMoreModal(_ content...) in the shared/extensions/form.

I originally had this idea where, like the ScrollIfLargerThanContainerModifer, it would determine the content size then be focusable and scrollable if exceeds the size.

The other option is similar to the marquee we have where it auto-scrolls.

Might be worth playing around with the options and seeing what makes the most sense. For now, that modal usage for tvOS can be found on the PlayerType Selector

[henryauryn]

Hey, I'd love to work on this as my first issue if it's still available.

It is available! As a note, there are still 2 modals for LearnMoreModal. We are in the process of unifying our settings so we have a single settings file that works for both tvOS and iOS. As a result, there LearnMoreModal stand along file is getting taken out as we finalize migrating over our last settings.

You will want to make your changes to to the LearnMoreModal found in the Form extension. Should be func learnMoreModal(_ content...) in the shared/extensions/form.

I originally had this idea where, like the ScrollIfLargerThanContainerModifer, it would determine the content size then be focusable and scrollable if exceeds the size.

The other option is similar to the marquee we have where it auto-scrolls.

Might be worth playing around with the options and seeing what makes the most sense. For now, that modal usage for tvOS can be found on the PlayerType Selector

Great, thank you - I'll play around

[JPKribs]

Sounds good! Let me know if you have any questions or anything I can help answer while you look at this.

[henryauryn]

Sounds good! Let me know if you have any questions or anything I can help answer while you look at this.

Great, thank you. I've been experimenting for a little while now, and just submitted a draft PR so you can look at the changes. I detailed the last little issue I'm having a hard time clearing up, if you have a chance to help me a little.

I only started Swift/SwiftUI dev a couple months ago, and am an undergrad student so I am sure I am missing stuff haha