[JENKINS-76228] Jenkinsfile not found for reopened PR on GitHub

[jenkins-infra-bot]

We are still facing the same issue as JENKINS-54126 even with the fix https://github.com/hub4j/github-api/blob/github-api-1.321/src/main/java/org/kohsuke/github/GitHubClient.java#L778.
I cannot find the log “Encountered GitHub invalid cached 404…” in Jenkins log.
 
Infra:
Jenkins core 2.504.2
GitHub Branch Source 1822.v9eec8e5e69e3
 
Reproduce steps: 
1. Open a PR

2. Make sure PR has been indexed on Jenkins

3. Close this PR, Scan repository on Jenkins

4. Reopen this PR, scan repository on Jenkins again  - and see in logs:

Getting remote pull requests...
Checking pull request #2
‘Jenkinsfile’ not found
Does not meet criteria

 

---

Originally reported by jenna_chen, imported from: Jenkinsfile not found for reopened PR on GitHub

• assignee: bitwiseman
• status: Open
• priority: Blocker
• component(s): github-api-plugin, github-branch-source-plugin
• resolution: Unresolved
• votes: 0
• watchers: 5
• imported: 2025-12-02

Raw content of original issue

We are still facing the same issue as JENKINS-54126 even with the fix https://github.com/hub4j/github-api/blob/github-api-1.321/src/main/java/org/kohsuke/github/GitHubClient.java#L778.
I cannot find the log “Encountered GitHub invalid cached 404…” in Jenkins log.
 
Infra:
Jenkins core 2.504.2
GitHub Branch Source 1822.v9eec8e5e69e3
 
Reproduce steps: 
1. Open a PR

2. Make sure PR has been indexed on Jenkins

3. Close this PR, Scan repository on Jenkins

4. Reopen this PR, scan repository on Jenkins again  - and see in logs:

Getting remote pull requests...
Checking pull request #2
‘Jenkinsfile’ not found
Does not meet criteria


 

environment

Jenkins core 2.504.2<br/>
GitHub Branch Source 1822.v9eec8e5e69e3

[jenkins-infra-bot]

jenna_chen:

• Original comment link
• Raw content of original comment:

  The fallback logic isn't triggered because the 'Etag' field is null in the response of our GitHub server.
  
  I'm wondering if the three prerequisites of the fallback logic are all necessary ?
  
  if (connectorResponse.statusCode() == 404
     && Objects.equals(connectorResponse.request().method(), "GET")
     && connectorResponse.header("ETag") != null
     && !Objects.equals(connectorResponse.request().header("Cache-Control"),"no-cache")) {}
  
  

The fallback logic isn't triggered because the 'Etag' field is null in the response of our GitHub server.

I'm wondering if the three prerequisites of the fallback logic are all necessary ?

if (connectorResponse.statusCode() == 404
   && Objects.equals(connectorResponse.request().method(), "GET")
   && connectorResponse.header("ETag") != null
   && !Objects.equals(connectorResponse.request().header("Cache-Control"),"no-cache")) {}