Add descending order, natural sorting, and count limit for tag discovery#1501
Open
kkupciunas wants to merge 6 commits intojenkinsci:masterfrom
Open
Add descending order, natural sorting, and count limit for tag discovery#1501kkupciunas wants to merge 6 commits intojenkinsci:masterfrom
kkupciunas wants to merge 6 commits intojenkinsci:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In repositories with a large number of tags (hundreds, thousands), the current tag discovery behavior scans all tags in ascending alphabetical order (as returned by GH API). Projects that use incremental release tagging approach (e.g. semver), suffer from this behavior, because usually the newest tags are the last ones. This makes the scanning process very slow and eats up GH API calls.
This patchset adds 3 related improvements for tag discovery:
v0.1.11>v.0.1.2,v10.0.0>v9.0.0`) and works for any alphanumeric naming, not just semver.Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify