remove invisible entry from drop down list

[car-roll]

• JENKINS issue(s):
  • NGPIPELINE-775
• Description:
  • When adding a github source, the API endpoint drop down list is partially visible when the Repository Scan radio button is selected.

The problem appears to be in the GithubSCMSource jelly (config-detail.jelly). If there are no API Endpoints, an invisibleEntry is added to the radioBlock. However, it looks like there is a bug that invisibleEntries are still partially visible in a radioBlock.
(Technically, the list of API Endpoints is never empty as it always has a "Github" title as the first entry. I confirmed that the bug was still present when the list was truly empty.)

Since there is no reason to store an empty list of API Endpoints in an invisible entry, I completely removed the logic and the issue went away.

• Documentation changes:
  • bugfix, no documentation changes
• Users/aliases to notify:
  • See reviewers list

[dwnusbaum]

Ok, I guess this works because apiUri is always set to something in GitHubScmSource's constructor as of #236? Did you manually test in a scenario where there are some options in the dropdown to make sure everything still works correctly? (I think it should be fine)

[car-roll]

@dwnusbaum technically there are always options in the drop down because the add the title Github in the drop down here.
I've tested with the drop down completely empty as well as the API endpoint always visible. Did you mean testing it with some valid endpoints? I didn't know of any enterprise servers to test it with.

[dwnusbaum]

@car-roll Yeah, I mean testing a scenario where you select a GitHub Enterprise server from the dropdown to make sure that still works correctly.

[kshultzCB]

Approved, pending a quick verification that >1 endpoint displays correctly.

This will be a nice change. I've always hated that little fragment of a dropdown. :)

[car-roll]

tested adding a github enterprise server. Was able to connect successfully and scan an empty test repo with two branches.