Skip to content

[JENKINS-69815] Introduce a cache for private mode check#700

Merged
rsandell merged 7 commits intojenkinsci:masterfrom
rsandell:JENKINS-69815
Jun 5, 2023
Merged

[JENKINS-69815] Introduce a cache for private mode check#700
rsandell merged 7 commits intojenkinsci:masterfrom
rsandell:JENKINS-69815

Conversation

@rsandell
Copy link
Copy Markdown
Member

@rsandell rsandell commented Jun 1, 2023

Description

Another attempt like #698
See
JENKINS-69815 for further information.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Automated tests have been added to exercise the changes
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verify that the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

@basil
Copy link
Copy Markdown
Member

basil commented Jun 1, 2023

@car-roll car-roll added the bug label Jun 2, 2023
@rsandell rsandell marked this pull request as ready for review June 2, 2023 14:23
Co-authored-by: Carroll Chiou <cchiou@cloudbees.com>
@rsandell rsandell merged commit df12377 into jenkinsci:master Jun 5, 2023
@rsandell rsandell deleted the JENKINS-69815 branch June 5, 2023 14:00
@jglick
Copy link
Copy Markdown
Member

jglick commented Sep 7, 2023

All this complexity is so we can decide whether AvatarMetadataAction should provide a logo for the org folder? #532 by @Vlatombe IIUC. Better to just delete this feature if it is causing problems, or set an icon once when you create an org folder, or offer some button in the config page to download and apply an icon, anything. This is just not important enough to be computing during retrieveActions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants