Support multiple notifications#7
Merged
Merged
Conversation
d9f4ba3 to
fe204e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for sending multiple Github status notifications for a single build.
This can be useful if using multiple jobs where one is based on pull requests and the other is based on branches NOT included in pull requests. If the latter/branch build uses a status notification which is configured as a status check in Github, that status will not be reported to Github when a branch is part of a pull request. Assuming the pull request job performs at least the same functions as the branch job, it is helpful to have the pull request job configure the same status as the branch job in order to ensure the necessary statuses are reported to Github.
Testing done
After making changes:
mvn hpi:run.