Skip to content

Support multiple notifications#7

Merged
l3ender merged 9 commits into
jenkinsci:masterfrom
l3ender:multiple-notifications
Sep 24, 2023
Merged

Support multiple notifications#7
l3ender merged 9 commits into
jenkinsci:masterfrom
l3ender:multiple-notifications

Conversation

@l3ender

@l3ender l3ender commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

Overview

This PR adds support for sending multiple Github status notifications for a single build.

This can be useful if using multiple jobs where one is based on pull requests and the other is based on branches NOT included in pull requests. If the latter/branch build uses a status notification which is configured as a status check in Github, that status will not be reported to Github when a branch is part of a pull request. Assuming the pull request job performs at least the same functions as the branch job, it is helpful to have the pull request job configure the same status as the branch job in order to ensure the necessary statuses are reported to Github.

Testing done

After making changes:

  1. Ran project locally using mvn hpi:run.
  2. Installed Pipeline plugin in Jenkins.
  3. Created multibranch pipeline job referencing test Github repo.
  4. Added this plugin's behavior and triggered build to observe statuses being reported to Github.
### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@l3ender l3ender force-pushed the multiple-notifications branch from d9f4ba3 to fe204e3 Compare September 22, 2023 14:15
@l3ender l3ender added the enhancement New feature or request label Sep 24, 2023
@l3ender l3ender merged commit fa7f31a into jenkinsci:master Sep 24, 2023
@l3ender l3ender deleted the multiple-notifications branch September 24, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant