Rework expiring s3 urls for media attachments #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesseplusplus
force-pushed
the
remove-expiring-media-urls
branch
from
6493bd1 to
c358d22
Compare
jesseplusplus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expiring signed urls for media attachments were added in #9 as a potential way to secure media for private posts, but this scheme does not play well on its own with federation since remote servers do not refetch a new url when the old one expires. Since the first implementation, the media proxy has been added.
This PR:
expires_inoption when getting any paperclip attachment url (while continuing to sign the url with the default s3 expiration)expires_inoption to the media proxy and sets it for a shorter duration of 15 minutes