Dispose document when tearing down JSDom environment#5955
Merged
mjesun merged 1 commit intojestjs:masterfrom Apr 10, 2018
mjesun:dispose-document
Merged
Dispose document when tearing down JSDom environment#5955mjesun merged 1 commit intojestjs:masterfrom mjesun:dispose-document
mjesun merged 1 commit intojestjs:masterfrom
mjesun:dispose-document
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5955 +/- ##
==========================================
- Coverage 64.34% 64.33% -0.01%
==========================================
Files 217 217
Lines 8285 8286 +1
Branches 4 4
==========================================
Hits 5331 5331
- Misses 2953 2954 +1
Partials 1 1
Continue to review full report at Codecov.
|
thymikee
approved these changes
Apr 10, 2018
Contributor
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
LGTM. A test would be nice to make sure this doesn't change in newer versions of jsdom
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
loadevent is triggered asynchronously by JSDom, and, since it happens into the constructor, nothing can be done.However, an early check for
documentexistence is done before (as you wouldn't be able to check its status if it's already gone). Based on this, for synchronous tests, we can skip theloadevent, which was anyway triggered later.