Remove Rollbar logging and update commitlint configuration#1469
Closed
Remove Rollbar logging and update commitlint configuration#1469
Conversation
Removed rollbar logging for places that were observed to always have bad user input data and were not actual bugs Minor code cleanup
There was a problem hiding this comment.
Pull request overview
This PR removes Rollbar error logging from areas experiencing consistent bad user input and updates the commitlint configuration to enforce stricter commit message formatting. The changes improve code maintainability by replacing verbose Rollbar logging with simpler logger.warn calls and refactoring if-else chains into more readable sequential if statements.
- Removed Rollbar error logging from formatter functions and error handlers
- Refactored if-else chains to sequential if statements for improved readability
- Migrated commitlint configuration from CommonJS to TypeScript with type-safe enums
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
libs/ui/src/lib/sobject-field-list/SobjectFieldListTypeRollupSummaryDetails.tsx |
Added null check before accessing query results and removed Rollbar error logging from catch block |
libs/ui/src/lib/data-table/data-table-formatters.tsx |
Replaced Rollbar logging with logger.warn calls across all formatter functions and refactored if-else chains to sequential if statements |
libs/features/load-records/src/components/load-results/LoadRecordsBulkApiResults.tsx |
Removed Rollbar error logging and unused import for error handling utility |
commitlint.config.ts |
Converted configuration from CommonJS to TypeScript with proper type imports and added body-max-line-length rule |
Comments suppressed due to low confidence (1)
commitlint.config.ts:26
- This inline comment appears to be unnecessary and incomplete. If it's meant to indicate something, it should be replaced with a meaningful comment or removed entirely.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate Rollbar logging from areas with consistent bad user input and perform minor code cleanup. Update the commitlint configuration to enforce a maximum body line length.