Open
Conversation
Reduced Angular change detection triggers from ~5+ per HTTP request down to 1 (or 0 if no observers). Key optimizations: - Wrapped HttpClient calls in `runOutsideAngular()` to prevent zone.js from triggering CD on XHR progress events (send, download, load, etc.) - Re-enter Angular zone with `ngZone.run()` only when emitting to @output() with active observers - Added AbortController to make async render operations cancellable (Promises are not cancellable by default in JavaScript) - Used switchMap to automatically cancel stale in-flight requests when src changes rapidly Performance impact: - Before: HTTP request triggers 5+ CD cycles (one per XHR event) - After: HTTP request triggers 1 CD cycle (only on final emission, and only if observers exist) --- Note: Also updated demo app during debugging session. The demo had scroll event handlers triggering redundant change detections, which made it harder to profile the markdown component's actual CD behavior. These demo changes aren't strictly necessary for the optimization but were helpful for accurate performance measurement.
Contributor
Author
|
@jfcere please note that some formatting changes have been done automatically, I was trying to revert them, but they're still being formatted once I click save. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduced Angular change detection triggers from ~5+ per HTTP request down to 1 (or 0 if no observers).
Key optimizations:
runOutsideAngular()to prevent zone.js from triggering CD on XHR progress events (send, download, load, etc.)ngZone.run()only when emitting to @output() with active observersPerformance impact:
Note: Also updated demo app during debugging session. The demo had scroll event handlers triggering redundant change detections, which made it harder to profile the markdown component's actual CD behavior. These demo changes aren't strictly necessary for the optimization but were helpful for accurate performance measurement.