Added flexpack build info support for poetry by agrasth · Pull Request #140 · jfrog/jfrog-cli-artifactory

agrasth · 2025-08-28T10:44:05Z

All tests passed. If this feature is not already covered by the tests, I added new tests.
All static analysis checks passed.
Appropriate label is added to auto generate release notes.
I used gofmt for formatting the code before submitting the pull request.
PR description is clear and concise, and it includes the proposed solution/fix.

bhanurp · 2025-08-29T01:26:59Z

artifactory/commands/python/poetry.go

+		// Create Poetry FlexPack instance
+		poetryFlex, err := flexpack.NewPoetryFlexPack(config)
+		if err != nil {
+			log.Warn("Failed to create Poetry FlexPack, falling back to standard method: " + err.Error())


Do we need this warning message? the error can be returned and even the else statement can be removed since we are returning in if block

ok will return error in this case

bhanurp · 2025-08-29T01:38:17Z

artifactory/commands/python/poetry.go

-	err := pc.install(buildConfiguration, pythonBuildInfo)
+
+	// Get build name and number
+	buildName, err := buildConfiguration.GetBuildName()


Not on priority: we need to check if we really need to read buildName and number from project.yaml which is happening in buildConfiguration.GetBuildName()

bhanurp · 2025-08-29T01:40:02Z

artifactory/commands/python/poetry.go

+			// Collect build info using FlexPack
+			flexBuildInfo, err := poetryFlex.CollectBuildInfo(buildName, buildNumber)
+			if err != nil {
+				log.Warn("Failed to collect build info with FlexPack, falling back to standard method: " + err.Error())


we should return error since we failed collecting build info instead of warning

bhanurp · 2025-08-29T01:40:30Z

artifactory/commands/python/poetry.go

+				err = pc.saveFlexPackBuildInfo(flexBuildInfo)
+				if err != nil {
+					log.Warn("Failed to save FlexPack build info: " + err.Error())
+				} else {
+					log.Info("Successfully saved FlexPack build info with dependencies")
+				}


Suggested change

err = pc.saveFlexPackBuildInfo(flexBuildInfo)

if err != nil {

log.Warn("Failed to save FlexPack build info: " + err.Error())

} else {

log.Info("Successfully saved FlexPack build info with dependencies")

}

return pc.saveFlexPackBuildInfo(flexBuildInfo)

bhanurp · 2025-08-29T01:41:19Z

artifactory/commands/python/poetry.go

+		// Create FlexPack Poetry configuration
+		config := flexpack.PoetryConfig{
+			WorkingDirectory:       workingDir,
+			IncludeDevDependencies: false, // Match standard behavior


default should be false right do we need this?

Suggested change

IncludeDevDependencies: false, // Match standard behavior

you are right, will update this

bhanurp · 2025-08-29T01:49:37Z

artifactory/commands/python/poetry.go

+	err = bld.SaveBuildInfo(buildInfo)
+	if err != nil {
+		return fmt.Errorf("failed to save build info: %w", err)
+	}
+
+	return nil


Suggested change

err = bld.SaveBuildInfo(buildInfo)

if err != nil {

return fmt.Errorf("failed to save build info: %w", err)

}

return nil

return bld.SaveBuildInfo(buildInfo)

bhanurp · 2025-08-29T01:52:26Z

artifactory/commands/python/poetry.go

+
+// getProjectNameFromPyproject extracts project name from pyproject.toml
+func (pc *PoetryCommand) getProjectNameFromPyproject(workingDir string) (string, error) {
+	pyprojectPath := filepath.Join(workingDir, "pyproject.toml")


Create a constant for "pyproject.toml".

bhanurp · 2025-08-29T02:02:25Z

artifactory/commands/python/poetry.go

+// collectPublishedArtifacts collects information about artifacts that were published
+func (pc *PoetryCommand) collectPublishedArtifacts(buildConfiguration *buildUtils.BuildConfiguration, pythonBuildInfo *build.Build, workingDir string) error {
+	// Look for built artifacts in dist/ directory
+	distDir := filepath.Join(workingDir, "dist")


can poetry write published artifacts to a different directory instead of default?

bhanurp · 2025-08-29T02:02:40Z

artifactory/commands/python/poetry.go

+}
+
+// findDistArtifacts finds and creates artifact entries for files in dist directory
+func (pc *PoetryCommand) findDistArtifacts(distDir string) ([]entities.Artifact, error) {


cant this be read from pyproject.toml?

Ok I can add a method for this

bhanurp · 2025-08-29T02:06:38Z

artifactory/commands/python/poetry.go

+
+		filename := entry.Name()
+		// Only include wheel and tar.gz files
+		if !strings.HasSuffix(filename, ".whl") && !strings.HasSuffix(filename, ".tar.gz") {


just to improve readability

Suggested change

if !strings.HasSuffix(filename, ".whl") && !strings.HasSuffix(filename, ".tar.gz") {

if !(strings.HasSuffix(filename, ".whl") || !strings.HasSuffix(filename, ".tar.gz")) {

you can also reuse the function getArtifactType here

yeah, great point, I will update this to use getArtifactType.

agrasth had a problem deploying to frogbot August 28, 2025 10:44 — with GitHub Actions Failure

bhanurp requested changes Aug 29, 2025

View reviewed changes

agrasth added the new feature Automatically generated release notes label Sep 2, 2025

agrasth force-pushed the flexpack branch from 9682537 to c200217 Compare September 2, 2025 21:24

agrasth had a problem deploying to frogbot September 2, 2025 21:24 — with GitHub Actions Failure

agrasth force-pushed the flexpack branch from c200217 to e17eac1 Compare September 3, 2025 07:20

agrasth had a problem deploying to frogbot September 3, 2025 07:20 — with GitHub Actions Failure

agrasth force-pushed the flexpack branch from e17eac1 to 5c7e286 Compare September 3, 2025 08:54

agrasth had a problem deploying to frogbot September 3, 2025 08:54 — with GitHub Actions Failure

agrasth force-pushed the flexpack branch from 5c7e286 to 90c01ee Compare September 3, 2025 09:01

agrasth had a problem deploying to frogbot September 3, 2025 09:01 — with GitHub Actions Failure

agrasth force-pushed the flexpack branch from 90c01ee to 9567823 Compare September 7, 2025 21:02

agrasth had a problem deploying to frogbot September 7, 2025 21:02 — with GitHub Actions Failure

Added flexpack build info support for poetry

8220ddd

agrasth force-pushed the flexpack branch from 9567823 to 8220ddd Compare September 7, 2025 21:06

agrasth had a problem deploying to frogbot September 7, 2025 21:07 — with GitHub Actions Failure

agrasth merged commit fb4679f into jfrog:main Sep 7, 2025
10 of 11 checks passed

	if !strings.HasSuffix(filename, ".whl") && !strings.HasSuffix(filename, ".tar.gz") {
	if !(strings.HasSuffix(filename, ".whl") \|\| !strings.HasSuffix(filename, ".tar.gz")) {

Conversation

agrasth commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

agrasth commented Aug 28, 2025 •

edited

Loading