Setup command - fix twine and docker#157
Merged
sverdlov93 merged 22 commits intomainfrom Sep 14, 2025
Merged
Conversation
# Conflicts: # artifactory/commands/setup/setup.go
sverdlov93
had a problem deploying
to
frogbot
GitHub Actions
Failure
sverdlov93
added
the
safe to test
omerzi
approved these changes
Sep 14, 2025
sverdlov93
changed the title
…lity - Add getAvailablePipExecutable() function to detect available pip executable (pip or pip3) - Optimize RunConfigCommand to only use detection for pip build tool - Add comprehensive tests for pip detection logic - Fixes issue where systems with only pip3 would fail during pip config operations
The function was accidentally omitted in the previous commit due to git conflict. Now properly implements pip/pip3 detection and optimized RunConfigCommand logic.
…tion - Replace getAvailablePipExecutable() with generic getExecutable(buildTool) - Move all build tool executable logic from RunConfigCommand to getExecutable() - Use switch statement for extensible build tool handling - Cleaner RunConfigCommand with single function call instead of if/else logic - Add comprehensive tests for getExecutable with multiple build tools - Better separation of concerns and easier future extensibility
sverdlov93
had a problem deploying
to
frogbot
GitHub Actions
Failure
omerzi
approved these changes
Sep 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also added informative errors