Skip to content

Go setup - Remove direct suffix go setup#158

Merged
sverdlov93 merged 20 commits intomainfrom
remove-direct-suffix-go-setup
Sep 14, 2025
Merged

Go setup - Remove direct suffix go setup#158
sverdlov93 merged 20 commits intomainfrom
remove-direct-suffix-go-setup

Conversation

@sverdlov93
Copy link
Copy Markdown
Collaborator

@sverdlov93 sverdlov93 commented Sep 14, 2025 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • Appropriate label is added to auto generate release notes.
  • I used gofmt for formatting the code before submitting the pull request.
  • PR description is clear and concise, and it includes the proposed solution/fix.
  • Remove ',direct' from Go proxy URL comment documentation
  • Change GoProxyUrlParams Direct parameter from true to false
  • This removes the direct fallback from the Go proxy configuration

@sverdlov93
setup command improvments
a41f8db
@sverdlov93
setup command improvments
7a26492
@sverdlov93
setup command improvments
f86599a
@sverdlov93
setup command improvments
7f8d743
@sverdlov93
setup command improvments
7466834
@sverdlov93
setup command improvments
f36a0b9
@sverdlov93
setup command improvments
62188e8
@sverdlov93
setup command improvments
aec4ac8
@sverdlov93
setup command improvments
7a5a7c6
@sverdlov93
setup command improvments
196effd
@sverdlov93
setup command improvments
b50f088
@sverdlov93
setup command improvments
211dafd
@sverdlov93
setup command improvments
ba97674
@sverdlov93
Merge branch 'main' of https://github.com/jfrog/jfrog-cli-artifactory
c97a861 
# Conflicts:
#	artifactory/commands/setup/setup.go
@sverdlov93
Merge branch 'main' of https://github.com/jfrog/jfrog-cli-artifactory
c9e4bf0
@sverdlov93
Merge branch 'main' of https://github.com/jfrog/jfrog-cli-artifactory
294edf2
@sverdlov93
Merge branch 'main' of https://github.com/jfrog/jfrog-cli-artifactory
af023cc
@sverdlov93
Merge branch 'main' of https://github.com/jfrog/jfrog-cli-artifactory
1c4b719
@sverdlov93
cd /Users/michaelsv/IdeaProjects/jfrog-cli-artifactoryMerge branch 'm…
f537f6c 
…ain' of https://github.com/jfrog/jfrog-cli-artifactory
@sverdlov93
Remove direct suffix from Go proxy setup configuration
060bae7 
- Remove ',direct' from Go proxy URL comment documentation
- Change GoProxyUrlParams Direct parameter from true to false
- This removes the direct fallback from the Go proxy configuration
@sverdlov93 sverdlov93 added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Sep 14, 2025
@sverdlov93 sverdlov93 merged commit 4430266 into main Sep 14, 2025
19 of 21 checks passed
@sverdlov93 sverdlov93 deleted the remove-direct-suffix-go-setup branch September 14, 2025 16:28
sverdlov93 added a commit that referenced this pull request Dec 30, 2025
@sverdlov93
Revert "Go setup - Remove direct suffix go setup (#158)"
d07472e 
This reverts commit 4430266.
@sverdlov93 sverdlov93 mentioned this pull request Dec 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yahavi yahavi yahavi approved these changes

Assignees

No one assigned

Labels

improvement Automatically generated release notes safe to test Approve running integration tests on a pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sverdlov93 @yahavi