Github committer reviewer evidence on buildinfo#46
Open
lesnerd wants to merge 2 commits intojfrog:mainfrom
Open
Github committer reviewer evidence on buildinfo#46lesnerd wants to merge 2 commits intojfrog:mainfrom
lesnerd wants to merge 2 commits intojfrog:mainfrom
Conversation
Contributor
lesnerd
commented
Feb 16, 2025
lesnerd
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
lesnerd
force-pushed
the
committer-reviewer
branch
from
98c6b17 to
373315d
Compare
oshratZairi
reviewed
Feb 17, 2025
go.mod
Outdated
|
|
||
| go 1.23.4 | ||
|
|
||
| toolchain go1.23.5 |
Contributor
There was a problem hiding this comment.
To my knowledge - why does it need to be added?
evidence/create_github.go
Outdated
|
|
||
| func getFlagType(typeFlag string) FlagType { | ||
| var flagType FlagType | ||
| if typeFlag == "gh-commiter" { |
Contributor
There was a problem hiding this comment.
please consider adding const for this value
| } | ||
|
|
||
| func (c *createGitHubEvidence) CommandName() string { | ||
| return "create-github-evidence" |
Contributor
There was a problem hiding this comment.
please consider adding const for this value
lesnerd
force-pushed
the
committer-reviewer
branch
from
43a273e to
f8a53ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.