Introduce multiple sources support and support new source 'package'#81
Introduce multiple sources support and support new source 'package'#81rimapol merged 37 commits intojfrog:mainfrom
Conversation
…ined in spec and support new source type
bhanurp
left a comment
bhanurp
left a comment
There was a problem hiding this comment.
please add more unit tests where ever required.
Co-authored-by: Bhanu Reddy <bhanur@jfrog.com>
Co-authored-by: Bhanu Reddy <bhanur@jfrog.com>
cliutils/flagkit/flags.go
Outdated
| SourcesReleaseBundles = "sources-release-bundles" | ||
| SourcesBuilds = "sources-builds" |
There was a problem hiding this comment.
I still think this suggestion makes sense
@fluxxBot these are definitions from product. As I wrote before. Let's leave it as is.
go.mod
Outdated
| module github.com/jfrog/jfrog-cli-artifactory | ||
|
|
||
| go 1.23.7 | ||
| go 1.24.2 |
There was a problem hiding this comment.
can we please revert go version back to 1.23.7?
Updating go version is a serious change and can lead to unwanted consequences.
There's a separate task already created for this version upgradation.
There was a problem hiding this comment.
@fluxxBot I am agree with you, but I didn't do it specially. It was a result of resolving conflicts.
But if you insist, I'll try to revert
There was a problem hiding this comment.
not sure why you faced this conflict, because I can see that on main branch we still have version 1.23.7. here, please revert this for now
There was a problem hiding this comment.
I reverted. Please look at my last commit
3 participants
Uh oh!
There was an error while loading. Please reload this page.