Skip to content

Config #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jiajunwang wants to merge 5 commits into from
Closed

Config #9

jiajunwang wants to merge 5 commits into from

Conversation

@jiajunwang
Copy link
Owner

@jiajunwang jiajunwang commented Aug 7, 2020 •
edited
Loading

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

(apache#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)

Description

  • Here are some details about my PR, including screenshots of any UI changes:

(Write a concise description including what, why, how)

Tests

  • The following tests are written for this issue:

(List the names of added unit/integration tests)

  • The following is the result of the "mvn test" command on the appropriate module:

(Before CI test pass, please copy & paste the result of "mvn test")

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

huizhilu and others added 5 commits August 5, 2020 10:56
@huizhilu
Fix flaky test testGetChildrenOnLargeNumChildren (apache#1194)
ab4d4e3 
testGetChildrenOnLargeNumChildren becomes flaky after more commits are checked in because of reflection doesn't work as expected. This commit fixes it by replacing reflection with creating 110K children for the test.
Remove the unnecessary checks to allow cleaning up map/list fields in…
9fe2892 
… the ClusterConfig and InstanceConfig.

The null check or empty check disallow class users to clean up the corresponding fields.
This change remove these checkes in follow methods,
- ClusterConfig.setDefaultCapacityMap
- ClusterConfig.setGlobalRebalancePreference
- ClusterConfig.setAbnormalStateResolverMap
- InstanceConfig.setInstanceCapacityMap
Change the behavior when input null as the config value.
f487182
Address comment.
0e2f446
Add more check for the abnormal resolver configuration set method.
a4268b3
jiajunwang
jiajunwang commented Aug 7, 2020
View reviewed changes
Copy link
Owner Author

@jiajunwang jiajunwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review to trigger action for testing.

jiajunwang
jiajunwang commented Aug 7, 2020
View reviewed changes
Copy link
Owner Author

@jiajunwang jiajunwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

jiajunwang
jiajunwang commented Aug 7, 2020
View reviewed changes
Copy link
Owner Author

@jiajunwang jiajunwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more test

@jiajunwang jiajunwang closed this Aug 7, 2020
@jiajunwang jiajunwang reopened this Aug 7, 2020
jiajunwang
jiajunwang commented Aug 7, 2020
View reviewed changes
Copy link
Owner Author

@jiajunwang jiajunwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test again...

@jiajunwang jiajunwang closed this Aug 7, 2020
@jiajunwang jiajunwang reopened this Aug 7, 2020
@jiajunwang jiajunwang closed this Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zhangmeng916 zhangmeng916 zhangmeng916 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CheckedAndApproved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jiajunwang @zhangmeng916 @huizhilu